fix(NODE-3726): add optional option overloads of Db's createCollection function #3019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrtheboss
changed the title
|
@skrtheboss Hi there, thank you for submitting this suggestion. Could you clarify what issue you are running into? Currently, optional options do appear to be supported: for a promise, you can use |
This adds support for calling createCollection with optional options. This is useful if for example a wrapper function is used.
|
HI @dariakp . |
skrtheboss
changed the title
dariakp
changed the title
dariakp
reviewed
Oct 29, 2021
There was a problem hiding this comment.
Thanks for adding the tests to demonstrate your use case, we'll take a look at the changes in detail soon; meanwhile, I have created this ticket to track the PR: https://jira.mongodb.org/browse/NODE-3726
dariakp
added
tracked-in-jira
dariakp
approved these changes
Nov 2, 2021
dariakp
added
Team Review
dariakp
pushed a commit
that referenced
this pull request
Nov 2, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for optional options in createColelction.
What is changing?
This adds support for calling createCollection with optional options.
This is useful if for example a wrapper function is used.
Is there new documentation needed for these changes? No.
What is the motivation for this change?
Overloads do not allow optional options.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>